Make version generation consistent across build targets #3497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update each of the build processes to use the build-time version rather than the existing version. Also removing the
*
in our path, but not from the human-readable string.Implementation details
Update
build-integrated
to use the buildroot for version file update; update each make target/script/spec file to use theversion_gen=true
path in build-integrated.also note that this reverts a workaround in our builds 6e8c9a5
Testing
Tested on AL2 instance
Added a fresh commit then built for each of the following targets to be sure I was picking up the latest:
also checked that
make generic-deb-integrated
works, as it callsmake dockerfree-agent-image
to build the agent.And also note that I tested the koji-built agent and it is consistent already so no work required there:
https://github.com/aws/amazon-ecs-agent/releases/tag/v1.66.2 <- 06008fa
in the koji-built agent:
New tests cover the changes: no
Description for the changelog
Fix agent short hash version bug
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.