pulling gRPC dependencies vendor #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
3 times, most recently
from
92cc0a8 to
934c45b
Compare
singholt
requested changes
Oct 21, 2022
agent/taskresource/grpcclient/credentialsfetcher/credentialsfetcher.proto
Outdated
Show resolved
Hide resolved
singholt
reviewed
Oct 21, 2022
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
from
934c45b to
ad655ae
Compare
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
from
ad655ae to
0c1a41e
Compare
singholt
reviewed
Oct 21, 2022
singholt
changed the title
singholt
reviewed
Oct 21, 2022
singholt
reviewed
Oct 21, 2022
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
from
0c1a41e to
66b60ef
Compare
singholt
requested changes
Oct 21, 2022
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
2 times, most recently
from
e992240 to
a6edff2
Compare
singholt
previously approved these changes
Oct 22, 2022
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
from
a6edff2 to
715f5ce
Compare
chienhanlin
reviewed
Oct 23, 2022
chienhanlin
reviewed
Oct 24, 2022
chienhanlin
previously approved these changes
Oct 24, 2022
saikiranakula-amzn
force-pushed
the
grpc_vendor
branch
from
715f5ce to
bc43f0e
Compare
singholt
approved these changes
Oct 24, 2022
chienhanlin
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request does pull the dependencies of gRPC into the vendor module and also include the client changes for credentials-fetcher daemon, which is a needed component to support gMSA linux on ECS
Implementation details
Credentials-fetcher client is responsible for communication of ecs-agent with the credentials-fetcher gMSA daemon which runs on the instance host.
Testing
Added unit tests to include test the behavior of the credentials-fetcher client
Note for external contributors:
make testandmake run-integ-testscan run in a Linux developmentenvironment like your laptop.
go test -timeout=30s ./agent/...and.\scripts\run-integ.tests.ps1can run in a Windows development environmentlike your laptop. Please ensure unit and integration tests pass (on at least
one platform) before opening the pull request.
Once you open the pull request, there will be 14 automatic test checks on the bottom
of the pull request, please make sure they all pass before you merge it. You can
use
bot/testlabel to rerun the automatic tests multiple times.-->
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.