preparing an ecs agent and init merged branch for AL1 builds #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekchaudhry
approved these changes
Aug 17, 2022
prateekchaudhry
approved these changes
Aug 17, 2022
| GO111MODULE=on go get github.com/fzipp/gocyclo/cmd/[email protected] | ||
| go get golang.org/x/tools/cmd/goimports | ||
| go get github.com/golang/mock/mockgen | ||
| go get honnef.co/go/tools/cmd/staticcheck | ||
| GO111MODULE=on go get honnef.co/go/tools/cmd/[email protected] |
There was a problem hiding this comment.
nit: We have v0.3.2 in master, is it okay to have that here too?
There was a problem hiding this comment.
Nah, it breaks the static checks if I try with 0.3.2.
prateekchaudhry
approved these changes
Aug 17, 2022
fierlion
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Testing
initAgentIntegrationAL1make dockerfree-agent-imagedocker load < ecs-agent.tarNew tests cover the changes: N/A
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.