adding staging bucket stack, arm builds, some directions #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashdalfTheGray
changed the title
| Type: AWS::CodeBuild::Project | ||
| Properties: | ||
| Artifacts: | ||
| Type: CODEPIPELINE | ||
| ConcurrentBuildLimit: 10 | ||
| Description: A sample agent build on pr | ||
| Description: A pipeline to build ECS Agent artifacts, sign them, and copy them to the staging bucket |
There was a problem hiding this comment.
nit: Is it better to say pipeline stage or just codebuild project? Also is this the project that will sign the artifacts too or is it done by SigningCodeBuildProject?
There was a problem hiding this comment.
Oh, this is the description of the whole pipeline so I went with "pipeline" rather than "stage" and yeah, this pipeline will also sign using a CodeBuild project!
There was a problem hiding this comment.
Oh right! So probably it is a description of BuildAndSignCodePipeline instead?
| ECS_AGENT_TAR: ecs-agent.tar | ||
| ECS_AGENT_TAR_SIGNATURE: ecs-agent.tar.asc | ||
| exported-variables: | ||
| - CODEBUILD_BUILD_ID |
There was a problem hiding this comment.
Where do we use CODEBUILD_BUILD_ID? Or will we use it in later development?
There was a problem hiding this comment.
Yep, that's the thing that I'm going to use to take the logs from Cloudwatch logs and put the things in the S3 bucket.
prateekchaudhry
approved these changes
May 6, 2022
prateekchaudhry
approved these changes
May 6, 2022
fierlion
approved these changes
May 9, 2022
Comment on lines
+33
to
+34
| - echo "Install glibc-static for dockerfree make method" | ||
| - yum -y install glibc-static |
There was a problem hiding this comment.
not a blocker but #3206 we don't need this if we use pre-built pause containers.
fierlion
pushed a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
May 31, 2022
* separated the merge-build and pr-build buildspecs * aim the codebuild stack at the right buildspec * updated the buildspecs to release and sign arm variants as well * updated the build infrastructure to build for arm as well as amd archs * added a note about adding more artifacts to be signed and copied * fixing a couple of other things found in review * added a bucket stack with a bucket policy * missed a letter in the arm build naming * added a missed file in the build directory structure * updated the descriptions for all of the codebuild projects
fierlion
pushed a commit
to fierlion/amazon-ecs-agent
that referenced
this pull request
May 31, 2022
* separated the merge-build and pr-build buildspecs * aim the codebuild stack at the right buildspec * updated the buildspecs to release and sign arm variants as well * updated the build infrastructure to build for arm as well as amd archs * added a note about adding more artifacts to be signed and copied * fixing a couple of other things found in review * added a bucket stack with a bucket policy * missed a letter in the arm build naming * added a missed file in the build directory structure * updated the descriptions for all of the codebuild projects
rsheik29
pushed a commit
to rsheik29/amazon-ecs-agent
that referenced
this pull request
Jul 11, 2022
* separated the merge-build and pr-build buildspecs * aim the codebuild stack at the right buildspec * updated the buildspecs to release and sign arm variants as well * updated the build infrastructure to build for arm as well as amd archs * added a note about adding more artifacts to be signed and copied * fixing a couple of other things found in review * added a bucket stack with a bucket policy * missed a letter in the arm build naming * added a missed file in the build directory structure * updated the descriptions for all of the codebuild projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds a staging bucket stack to the infrastructure, integrates arm builds
Implementation details
Testing
New tests cover the changes: not applicable
Description for the changelog
Enhancement - added arm builds to the release pipeline and added a staging bucket stack
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.