[ECS Windows] ECS Exec feature for Windows workloads #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
force-pushed
the
feature/ecs_exec_windows
branch
from
f6676dd to
bc2452d
Compare
sharanyad
force-pushed
the
feature/ecs_exec_windows
branch
from
9c91a3a to
f28059f
Compare
This change fixes the following issues- - Golang base image is Windows release specific and is not scalable. The change introduced here ensures that the correct base image is being used instead of the generic golang image. Also, we will build the binary and then copy it to the container image. - We need to disable Go Module in order to build the binary. We enable it at the end of the script.
Previously, the Linux was running on older version of Golang. With the Golang version upgrade to 1.17, the refactoring was done to change the build tags. This commit is for the same refactoring to older commits of ECS Exec on Windows feature.
sharanyad
force-pushed
the
feature/ecs_exec_windows
branch
from
f28059f to
5ddc83b
Compare
sharanyad
approved these changes
Oct 19, 2021
angelcar
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the agent support for enabling ECS Exec feature for Windows workloads running on Amazon EC2.
The changes include-
Implementation details
The commits were vetted in their respective PRs.
Testing
Unit tests, integration tests, and functional tests were executed to ensure existing functionality is not broken by the feature changes.
To validate the ECS exec feature changes, custom AMI was built and the workflow was tested on a Windows EC2 instance.
New tests cover the changes:
Yes
Description for the changelog
Enabling ECS Exec for Windows workloads running on ECS EC2
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.