V1.52.2 stage #2875
Merged
V1.52.2 stage #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienhanlin
previously approved these changes
May 20, 2021
chienhanlin
reviewed
May 20, 2021
| ## 1.52.2 | ||
| * Enhancement - validate agent config file path permission on Windows [#2866](https://github.com/aws/amazon-ecs-agent/pull/2866) | ||
| * Bug - fix potential goroutine leak when closing websocket connections [#2854](https://github.com/aws/amazon-ecs-agent/pull/2854) | ||
| * Bug - fixes a bug where a task can be stuck in RUNNING indefinitely when a container can't be stopped due to an unresolved docker [bug](https://github.com/moby/moby/issues/41587) (see also the open [PR](https://github.com/moby/moby/pull/41588) in moby to fix the bug). |
There was a problem hiding this comment.
Could we add this log to the PR summary? Thank you!
angelcar
previously approved these changes
May 20, 2021
chienhanlin
reviewed
May 20, 2021
agent/version/version.go
Outdated
|
|
||
| // GitDirty indicates the cleanliness of the git repo when this agent was built | ||
| const GitDirty = true | ||
|
|
||
| // GitShortHash is the short hash of this agent build | ||
| const GitShortHash = "3e46f380" | ||
| const GitShortHash = "9349e80e" |
There was a problem hiding this comment.
the new hash is cc51229 after the PR Give up trying to stop container if max timeouts are reached #2874 is merged : )
There was a problem hiding this comment.
i don't think this sha will be an actual commit sha because when you change this line the commit sha changes.. but anyway i updated it again with go run gen/version-gen.go
There was a problem hiding this comment.
ok! The sha cc51229 is shown under this PR's commits tab
There was a problem hiding this comment.
ok i see. updated, thanks!
angelcar
previously approved these changes
May 20, 2021
sparrc
previously approved these changes
May 20, 2021
angelcar
approved these changes
May 20, 2021
chienhanlin
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stage agent 1.52.2. Changelog:
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.