Changes to advertise updated OSType while registering ECS Windows instances #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepindraganti
changed the title
sandeepindraganti
changed the title
fenxiong
reviewed
Apr 30, 2021
fenxiong
reviewed
Apr 30, 2021
added 3 commits
April 30, 2021 19:10
sharanyad
reviewed
May 4, 2021
angelcar
reviewed
May 4, 2021
angelcar
reviewed
May 4, 2021
angelcar
approved these changes
May 6, 2021
rawahars
approved these changes
May 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Advertise OSFamilyType while registering the ECS instances with the cluster. Below are the supported OSTypes
Supported OS Types:
| | |Implementation details
Added a new implementation GetOperatingSystemFamilyType() which reads the windows registry and construct the relevant windows OS type. For Linux implementation it returns "Linux" as OS Type which is currently being returned. Linux behavior is unaltered by this PR
Testing
Unit tests written for the new changes.
Existing tests were executed
Custom agent built and verified.
Note for external contributors:
make testandmake run-integ-testscan run in a Linux developmentenvironment like your laptop.
go test -timeout=30s ./agent/...and.\scripts\run-integ.tests.ps1can run in a Windows development environmentlike your laptop. Please ensure unit and integration tests pass (on at least
one platform) before opening the pull request.
Once you open the pull request, there will be 14 automatic test checks on the bottom
of the pull request, please make sure they all pass before you merge it. You can
use
bot/testlabel to rerun the automatic tests multiple times.-->
New tests cover the changes:
Yes.
Description for the changelog
"Register Windows ECS Instances using specific OSFamilyType "
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.