Fix bug that could incorrectly clean up pause container before other containers #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2824 introduced a regression that could incorrectly clean up pause container before other containers. The expected behavior is that the pause container is stopped and cleaned after all other containers have stopped.
Implementation details
Reverting
stopContainermethod to before the regression, but keeping the pause container cleanup check after the task stops, which was the main intention of #2824.Testing
Added a second container to
TestPauseContainerHappyPathto verify the pause container is the last to be cleaned up and stopped, which was a missing check.New tests cover the changes: yes
Description for the changelog
Fix bug that could incorrectly clean up pause container before other containers
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.