-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ManagedAgent state change to task #2758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1394f48
to
d0b1e86
Compare
sharanyad
reviewed
Dec 10, 2020
angelcar
reviewed
Dec 10, 2020
d0b1e86
to
ddff5bf
Compare
ddff5bf
to
3f586ba
Compare
3f586ba
to
9d691c2
Compare
9d691c2
to
6aebb11
Compare
angelcar
reviewed
Dec 10, 2020
6aebb11
to
93499c0
Compare
angelcar
approved these changes
Dec 11, 2020
sharanyad
reviewed
Dec 11, 2020
93499c0
to
96b5e3b
Compare
96b5e3b
to
47d40a9
Compare
sharanyad
approved these changes
Dec 14, 2020
angelcar
pushed a commit
that referenced
this pull request
Dec 24, 2020
angelcar
pushed a commit
to angelcar/amazon-ecs-agent
that referenced
this pull request
Dec 29, 2020
ubhattacharjya
pushed a commit
that referenced
this pull request
Jan 16, 2021
angelcar
pushed a commit
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the ManagedAgent state change events from the Container state change events to the Task-level state change events to support bugfix model changes.
Implementation details
This adds batched ManagedAgent events to the Task event
Testing
I tested manually by building agent/init on an exec-capable container-instance and running 2 separate tasks, one with a single container and another with 3 containers
followed by:
I got the following output:
New tests cover the changes: Yes.
Description for the changelog
Migrate ManagedAgent state change from container to task event.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.