Cevoaustralia issue/2571 windows boolean env vars #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…insensitive platforms like Windows
…com/cevoaustralia/amazon-ecs-agent into cevoaustralia-issue/2571-windows-boolean-env-vars
yhlee-aws
force-pushed
the
cevoaustralia-issue/2571-windows-boolean-env-vars
branch
from
75f6138 to
729698d
Compare
fenxiong
approved these changes
Aug 17, 2020
mythri-garaga
approved these changes
Aug 17, 2020
yhlee-aws
deleted the
cevoaustralia-issue/2571-windows-boolean-env-vars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decoupling json parsing logic from env var parsing, which introduces errors depending on the value.
Implementation details
Explicitly checking for boolean and building BooleanDefault[True|False] objects instead of relying on json parsing logic.
Testing
New tests cover the changes: New unit tests added
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.