envfiles: remove sync call since we don't actually need to flush data… #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to disk, close file manually before rename
yhlee-aws
approved these changes
Mar 31, 2020
petderek
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to disk, close file manually before rename
Summary
This commit removes the .Sync call we make to flush files to disk - we don't actually need to flush data to disk in case the instance under agent crashes. In such a case, for environment files, the task resource would be created again anyway. This commit also calls .Close on the temporary file instead of deferring the close because windows was having issues with the file being open in another process during rename .
Implementation details
Testing
make testsuccessful, changes off forked branch tested against both AL2 and windows MACIS functional testsNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.