Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load image timeout based on benchmarking #2269

Merged
merged 2 commits into from
Nov 8, 2019
Merged

Update load image timeout based on benchmarking #2269

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e82d0d
Update load image timeout based on benchmarking.
fenxiong Nov 7, 2019
82bfa0c
Merge branch 'dev' into pauseload
fenxiong Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions agent/dockerclient/timeout.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,14 @@ const (
ListImagesTimeout = 10 * time.Minute
// LoadImageTimeout is the timeout for the LoadImage API. It's set
// to much lower value than pullImageTimeout as it involves loading
// image from either a file or STDIN
// calls involved.
// TODO: Benchmark and re-evaluate this value
LoadImageTimeout = 10 * time.Minute
// image from either a file or STDIN calls involved.
// This value is set based on benchmarking the time of loading the pause container image,
// since it's currently only used to load that image. If this is to be used to load any
// other image in the future, additional benchmarking will be required.
// Per benchmark, 2 min is roughly 4x of the worst case (29s) across 400 image loads on
// al1/al2/al2gpu/al2arm with smallest instance type available (t2.nano/a1.medium) and
// burst balance = 0.
LoadImageTimeout = 2 * time.Minute
// RemoveImageTimeout is the timeout for the RemoveImage API.
RemoveImageTimeout = 3 * time.Minute

Expand Down