allow unbounded ram tasks windows #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnxn
changed the title
added 2 commits
October 16, 2019 20:41
adnxn
force-pushed
the
coveord-allow-unbounded-ram-tasks-windows
branch
from
cd42477 to
d0eedb0
Compare
fenxiong
approved these changes
Oct 17, 2019
sharanyad
reviewed
Oct 17, 2019
README.md
Outdated
| @@ -170,6 +170,7 @@ additional details on each available environment variable. | |||
| | `ECS_CGROUP_PATH` | `/sys/fs/cgroup` | The root cgroup path that is expected by the ECS agent. This is the path that accessible from the agent mount. | `/sys/fs/cgroup` | Not applicable | | |||
| | `ECS_CGROUP_CPU_PERIOD` | `10ms` | CGroups CPU period for task level limits. This value should be between 8ms to 100ms | `100ms` | Not applicable | | |||
| | `ECS_ENABLE_CPU_UNBOUNDED_WINDOWS_WORKAROUND` | `true` | When `true`, ECS will allow CPU unbounded(CPU=`0`) tasks to run along with CPU bounded tasks in Windows. | Not applicable | `false` | | |||
| | `ECS_ENABLE_RAM_UNBOUNDED_WINDOWS_WORKAROUND` | `true` | When `true`, ECS will allow tasks with no memory reservation to run along with memory bounded tasks in Windows. To run a memory unbounded task, omit the memory hard limit and set any memory reservation, it will be ignored. | Not applicable | `false` | | |||
There was a problem hiding this comment.
what would be a good counterpoint for calling this ECS_ENABLE_MEMORY_UNBOUNDED_WINDOWS_WORKAROUND ?
There was a problem hiding this comment.
s/allow tasks with no memory reservation/ignore the memory reservation parameter (soft limit)/
agent/api/task/task_windows_test.go
Outdated
|
|
||
| // With RamUnbounded set to false, MemoryReservation is not overridden | ||
| config, configErr := testTask.DockerHostConfig(testTask.Containers[0], dockerMap(testTask), defaultDockerClientAPIVersion) | ||
| if configErr != nil { |
There was a problem hiding this comment.
this can be assert. same below
There was a problem hiding this comment.
you can use require.NoError(t, err) if you want the exit behavior you get from t.fatal
There was a problem hiding this comment.
agent/config/config_windows.go
Outdated
| @@ -118,8 +119,10 @@ func (cfg *Config) platformOverrides() { | |||
| cfg.TaskCPUMemLimit = ExplicitlyDisabled | |||
|
|
|||
| cpuUnbounded := utils.ParseBool(os.Getenv("ECS_ENABLE_CPU_UNBOUNDED_WINDOWS_WORKAROUND"), false) | |||
| ramUnbounded := utils.ParseBool(os.Getenv("ECS_ENABLE_RAM_UNBOUNDED_WINDOWS_WORKAROUND"), false) | |||
There was a problem hiding this comment.
I believe these need unit tests?
There was a problem hiding this comment.
added tests to check default config
adnxn
force-pushed
the
coveord-allow-unbounded-ram-tasks-windows
branch
2 times, most recently
from
b4d1504 to
2dbca13
Compare
sharanyad
approved these changes
Oct 18, 2019
rename the unbounded memory config for windows and add update unit tests
adnxn
force-pushed
the
coveord-allow-unbounded-ram-tasks-windows
branch
from
2dbca13 to
541f0d5
Compare
fenxiong
approved these changes
Oct 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
carrying over #2142 and testing. see #1144 and #2142 for context.
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.