Update task cleanup wait logic to clean task resources immediately in… #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssrivas
changed the title
|
Can you describe how did you verify that the task resources got cleaned up in the testing done section? |
ubhattacharjya
approved these changes
Jun 14, 2019
yumex93
approved these changes
Jun 17, 2019
mssrivas
force-pushed
the
Issues
branch
3 times, most recently
from
d392a81 to
01b5466
Compare
…stead of waiting 3 hours
mssrivas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update task cleanup wait logic to clean task resources immediately instead of waiting 3 hours
Summary
Currently if the clean up duration for tasks are not defined, It defaults to 3hr. The current logic in cleanupTask is once it passed the cleanup time, agent will wait for 3 more hours (DefaultTaskCleanupWaitDuration) instead of cleaning up the task immediately. Instead with below changes, it will begin cleanup immediately .
Implementation details
Once it passed the cleanup time, it waits a nanosecond and begins the cleanup task.
Testing
Created a task definition that uses a volume called test_vol. The check for successful clean being that docker volume ls does not return test_vol in the list.
Five cases tested.
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.