Adding functional test for Granular Stop Timeout #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubhattacharjya
changed the title
petderek
reviewed
Mar 26, 2019
| "cpu": 0, | ||
| "memory": 64, | ||
| "essential": false, | ||
| "command": ["sh", "-c", "trap 'echo caught' SIGTERM; sleep 60"], |
There was a problem hiding this comment.
is there any damage in doing 20 and 30 seconds? Instead of 50 and 60? Just to make test go a bit faster
petderek
reviewed
Mar 26, 2019
| @@ -362,6 +362,10 @@ func TestContainerOrderingTimeout(t *testing.T) { | |||
| t.Fatalf("Timed out waiting for task to reach stopped. Error %#v, task %#v", err, testTask) | |||
| } | |||
|
|
|||
| if exit, ok := testTask.ContainerExitcode("success-timeout-dependency"); !ok || exit != 137 { | |||
There was a problem hiding this comment.
? where did this come from?
petderek
approved these changes
Mar 26, 2019
ubhattacharjya
force-pushed
the
Granular
branch
from
9be61d3 to
c06ea8c
Compare
ubhattacharjya
force-pushed
the
Granular
branch
from
c06ea8c to
cb5a8f6
Compare
adnxn
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding functional tests for Granular Stop Timeout
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.