Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve functional testing for container ordering #1938

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Improve functional testing for container ordering #1938

merged 2 commits into from
Mar 25, 2019

Conversation

ubhattacharjya
Copy link
Contributor

@ubhattacharjya ubhattacharjya commented Mar 12, 2019 •
edited
Loading

Summary

Accomodate ecs_client Model Changes for functional testing and improve functional testing for container ordering to make sure that the containers are getting started in the correct order

Implementation details

Testing

New tests cover the changes:

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ubhattacharjya ubhattacharjya requested a review from a team March 12, 2019 23:04
@ubhattacharjya ubhattacharjya changed the title Model change Accomodate FE Model Changes into ecs_client package Mar 15, 2019
@ubhattacharjya ubhattacharjya changed the title Accomodate FE Model Changes into ecs_client package Accomodate ecs_client model changes Mar 15, 2019
@ubhattacharjya ubhattacharjya force-pushed the ModelChange branch 5 times, most recently from efa3067 to 3063a9b Compare March 15, 2019 18:45
@ubhattacharjya ubhattacharjya requested a review from a team March 15, 2019 18:45
@ubhattacharjya ubhattacharjya force-pushed the ModelChange branch 3 times, most recently from bc6a45a to 43ed551 Compare March 18, 2019 19:27
@ubhattacharjya ubhattacharjya changed the title Accomodate ecs_client model changes Improve functional testing for container ordering Mar 18, 2019
adnxn
adnxn reviewed Mar 20, 2019
View reviewed changes
Copy link
Contributor

@adnxn adnxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm - lets figure out whats going on with the failing tests though

fenxiong
fenxiong approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@fenxiong fenxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming the new tests passed

@ubhattacharjya
Copy link
Contributor Author

ubhattacharjya commented Mar 25, 2019 •
edited
Loading

All the new tests passed. The functional tests which are failing on arm are :
#1903
#1910
#1962

@ubhattacharjya ubhattacharjya merged commit 5d1d9a0 into aws:dev Mar 25, 2019
@ubhattacharjya ubhattacharjya added this to the 1.27.0 milestone Mar 27, 2019
@ubhattacharjya ubhattacharjya mentioned this pull request Apr 3, 2019
Closed
@ubhattacharjya ubhattacharjya deleted the ModelChange branch April 8, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suneyz suneyz suneyz left review comments

@fenxiong fenxiong fenxiong approved these changes

@adnxn adnxn adnxn approved these changes

Assignees
No one assigned
Labels
bot/test
Projects
None yet
Milestone
1.27.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ubhattacharjya @adnxn @suneyz @fenxiong @shubham2892