Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change task server endpoint to 127.0.0.1 #1901

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Change task server endpoint to 127.0.0.1 #1901

merged 1 commit into from
Feb 28, 2019

Conversation

suneyz
Copy link
Contributor

@suneyz suneyz commented Feb 27, 2019

Summary

Change task server endpoint to 127.0.0.1 from 0.0.0.0

Implementation details

Testing

  • curl localhost:51679 (server responsive)
  • curl hostip:51679 (server not responsive)

New tests cover the changes: No. Fixed some functional tests when switching to localhost.

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@suneyz suneyz added this to the 1.26.0 milestone Feb 27, 2019
@suneyz
Copy link
Contributor Author

suneyz commented Feb 28, 2019

@petderek petderek merged commit 8529bd8 into aws:dev Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yumex93 yumex93 yumex93 approved these changes

@yhlee-aws yhlee-aws yhlee-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@suneyz @yhlee-aws @yumex93 @petderek