merge master to dev "update to 1.25.3" #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhlee-aws
approved these changes
Feb 27, 2019
ubhattacharjya
approved these changes
Feb 27, 2019
aaithal
requested changes
Feb 27, 2019
|
@aaithal, this isn't a release PR. We didn't merge the changelog entry into both master and dev last time. |
|
Sorry, misread it, my bad. It's probably even more worrying that bringing
Sorry, misread it, my bad. It's probably even more worrying that bringing |
|
Part of it was I temporarily had our CI broken on windows integ / functional tests. I'm re-running those. |
|
tests passed. thanks derek! |
aaithal
approved these changes
Feb 28, 2019
fenxiong
added a commit
to fenxiong/amazon-ecs-agent
that referenced
this pull request
Feb 28, 2019
aws#1890 was merged using rebase and merge which is wrong, and dev is still "56 commits ahead, 1 commit behind master." Fixing by merging again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation details
Testing
New tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.