autocleanup nonECS Containers and Images #1722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
reviewed
Dec 7, 2018
yumex93
reviewed
Dec 10, 2018
yumex93
reviewed
Dec 10, 2018
yumex93
reviewed
Dec 10, 2018
yumex93
reviewed
Dec 11, 2018
haikuoliu
reviewed
Dec 11, 2018
| @@ -118,6 +118,9 @@ additional details on each available environment variable. | |||
| | `ECS_IMAGE_CLEANUP_INTERVAL` | 30m | The time interval between automated image cleanup cycles. If set to less than 10 minutes, the value is ignored. | 30m | 30m | | |||
| | `ECS_IMAGE_MINIMUM_CLEANUP_AGE` | 30m | The minimum time interval between when an image is pulled and when it can be considered for automated image cleanup. | 1h | 1h | | |||
| | `ECS_NUM_IMAGES_DELETE_PER_CYCLE` | 5 | The maximum number of images to delete in a single automated image cleanup cycle. If set to less than 1, the value is ignored. | 5 | 5 | | |||
| | `ECS_NONECS_IMAGE_CLEANUP_EXCLUDE` | amazonlinux:2, amazonlinux:1 | The imageCleanupExclusionList includes both ecs and nonecs images that agent won’t cleanup. | | | | |||
There was a problem hiding this comment.
Please have jole/eric to review readme
There was a problem hiding this comment.
readme file will keep at the next PR, need to sync with jole/eric before put PR out.
yumex93
reviewed
Dec 11, 2018
8 tasks
|
this pull request is older version, please refer to #1736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Automatically cleanup NonECS containers and NonECS images to reduce disk space usage for customers.
Implementation details
(1)Clean NonECS containers and images periodically.
(2)Each time period we delete the images limit ECS_NUM_IMAGES_DELETE_PER_CYCLE (default is 5).
(3)User are able to set env config (ECS_ENABLE_NONECS_IMAGES_REMOVE = true) to realize. Default value is false
(4)The NonECSImages eligible to be deleted sorted by the image size with ascending order.
(5)Users are able to specify the images that they don't want to remove for nonECS images.
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.