Update to 1.17.3 #1324
Merged
Update to 1.17.3 #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds Hostname and ExtraHosts to the pause container's docker config and host config respectively. This allows awsvpc tasks to have /etc/hosts entries for the ENI private ips
4.9 reached EOL in 2016 and is not available on Dockerhub anymore. Update the base image to 6.4 to fix this.
We're at least 2 years behind in this repo. Updated gomock to latest commit.
[1] Forcefully terminate connection if there's any error with the SetReadDeadline() call. Not doing this leads to unpredictable behavior with stale websocket connections. Since SetWriteDeadline always returns `nil`, errors from that are not handled. [2] Move WebsocketConn to its own package. This allows us to mock it out in the "wsclient" package and write unit tests on it.
Invoke 'goimports' while generating sdk artifacts. Generated targets were missing some imports and this fixes that issue. Also, refactored the code a bit to reduce duplication.
Added missing copyright headers for a couple of files
…data fields The task struct already has this information, so it's just a matter of plumbing it through. This commit also fixes some typos.
Previously the waitForContainerTransition will wait for all the transitions to be done before the container can move to next state. This PR changes the waitForContainerTransition to only wait for no more than one transition to be done so that the first container that done the transition doesn't need to wait for other containers.
adnxn
reviewed
Mar 30, 2018
CHANGELOG.md
Outdated
| * Enhancement - Expose task definition family and task definition revision in container metadata file [#1295](https://github.com/aws/amazon-ecs-agent/pull/1295) | ||
| * Enhancement - Fail image pulls if there's inactivity during image pull progress [#1290](https://github.com/aws/amazon-ecs-agent/pull/1290) | ||
| * Bug - Fixed a bug where a stale websocket connection could linger [#1310](https://github.com/aws/amazon-ecs-agent/pull/1310) | ||
| * Enhancement - Parallize the container transition in the same task [#1305](https://github.com/aws/amazon-ecs-agent/pull/1306) |
There was a problem hiding this comment.
nit: please swap ordering on the last two items,Bug should come at the end of the list
|
anddd we're missing one more PR > #1321 |
petderek
approved these changes
Mar 30, 2018
aaithal
reviewed
Mar 30, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,12 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.17.3-dev | |||
There was a problem hiding this comment.
Please make sure that -dev is deleted from this line
Test the start container time cost on windows instances with various parameters (instance type, container memory, container cpu, etc.), and set the default startContainerTimeouts value for windows accordingly. Also make the startContainerTimeouts configurable (via ECS_CONTAINER_START_TIMEOUT environment variable) by users.
yhlee-aws
force-pushed
the
dev
branch
3 times, most recently
from
f547308 to
e706a90
Compare
richardpen
reviewed
Mar 30, 2018
adnxn
approved these changes
Mar 30, 2018
acmcelwee
reviewed
Apr 5, 2018
| @@ -1,5 +1,13 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.17.3 | |||
| * Enhancement - Distinct startContainerTimeouts for windows/linux, introduce a new environment variable `ECS_CONTAINER_START_TIMEOUT` to make it configurable [#1321](https://github.com/aws/amazon-ecs-agent/pull/1321) | |||
| * Enhancement - Add support for containers to inhereit ENI private DNS hostnames for `awsvpc` tasks [#1278](https://github.com/aws/amazon-ecs-agent/pull/1278) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Agent 1.17.3 release
Implementation details
Merging dev branch into master for the release
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.