changelog: add entry for #1278 #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpen
reviewed
Mar 23, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.17.3-dev | |||
| * Enhancement - Add support for containers to inhereit ENI private dns hostnames for awsvpc tasks [#1278](https://github.com/aws/amazon-ecs-agent/pull/1278) | |||
There was a problem hiding this comment.
nit: DNS should be capitalized, and awsvpc should be quoted.
adnxn
force-pushed
the
changelog-eni-hostname
branch
from
a2b2904 to
4a388c0
Compare
richardpen
approved these changes
Mar 23, 2018
sharanyad
reviewed
Mar 23, 2018
CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.17.3-dev | |||
| * Enhancement - Add support for containers to inhereit ENI private DNS hostnames for "awsvpc" tasks [#1278](https://github.com/aws/amazon-ecs-agent/pull/1278) | |||
There was a problem hiding this comment.
This should be `awsvpc.. ?
There was a problem hiding this comment.
apparently it was for the 1.17.0 changelog 🤔
okay sure will make this change, although i did tell @richardpen id put quotes
adnxn
force-pushed
the
changelog-eni-hostname
branch
from
4a388c0 to
b91445c
Compare
sharanyad
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add changelog entry for PR #1278
Implementation details
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.