[wip] vendor: update aws-sdk-go to v1.12.5 #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petderek
approved these changes
Oct 5, 2017
samuelkarp
suggested changes
Oct 5, 2017
| "Rev": "b489cce1dd1ada60f519fe0dc70c096379a42214" | ||
| }, | ||
| { | ||
| "ImportPath": "github.com/aws/aws-sdk-go/vendor/github.com/go-ini/ini", |
There was a problem hiding this comment.
This should not be picked up and appears to be an error; nested vendors should be excluded by godep.
There was a problem hiding this comment.
hrm apparently it's a known issue tools/godep#498 (comment). ill try the work around described there.
adnxn
changed the title
|
blocked on dep migration #1009 |
|
closing since aws-sdk-go was updated with the cgroup changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updating aws-sdk-go to v1.12.5: b489cce
Implementation details
n/a
Testing
make release)go build -out amazon-ecs-agent.exe ./agent)make test) passgo test -timeout=25s ./agent/...) passmake run-integ-tests) pass.\scripts\run-integ-tests.ps1) passmake run-functional-tests) pass.\scripts\run-functional-tests.ps1) passNew tests cover the changes:
no
Description for the changelog
n/a
Licensing
This contribution is under the terms of the Apache 2.0 License:
yes