Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Explicitly initialize seelog
Browse files Browse the repository at this point in the history
The logger package's initialization logic is init() which will be
exected by loading the package.

However some of our programs are using the agent as a library and
haven't configured seelog beforehand. Due to that, loading the package
logs

```
1600397429848419666 [Error] node must have children
```
which breaks the programs.

I think it would be safer to do less on init() and explictly
initialize the logger from the agent's main().

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys committed Sep 18, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 953af90 commit c5db8df
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions agent/agent.go
Original file line number Diff line number Diff line change
@@ -19,12 +19,14 @@ import (
"time"

"github.com/aws/amazon-ecs-agent/agent/app"
"github.com/aws/amazon-ecs-agent/agent/logger"
)

func init() {
rand.Seed(time.Now().UnixNano())
}

func main() {
logger.Init()
os.Exit(app.Run(os.Args[1:]))
}
2 changes: 2 additions & 0 deletions agent/logger/log.go
Original file line number Diff line number Diff line change
@@ -181,7 +181,9 @@ func init() {
MaxFileSizeMB: DEFAULT_MAX_FILE_SIZE,
MaxRollCount: DEFAULT_MAX_ROLL_COUNT,
}
}

func Init() {
if err := seelog.RegisterCustomFormatter("EcsAgentLogfmt", logfmtFormatter); err != nil {
seelog.Error(err)
}

0 comments on commit c5db8df

Please sign in to comment.