Skip to content

Commit

Permalink
fix bug where the lock was never released
Browse files Browse the repository at this point in the history
There is a typo/bug in the `GetAppliedStatus` method for FSx task resource wherein the lock is never released in the method. This will likely cause the agent to fail tasks with FSx volume since the lock on other methods will never be acquired.

Presently, this method is not invoked from any workflow and therefore, we have not seen any impact.
  • Loading branch information
Harsh Rawat authored and Yiyuanzzz committed Feb 15, 2024
1 parent 9c32c89 commit 42e813a
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ func (fv *FSxWindowsFileServerResource) updateAppliedStatusUnsafe(knownStatus re
// GetAppliedStatus safely returns the currently applied status of the resource
func (fv *FSxWindowsFileServerResource) GetAppliedStatus() resourcestatus.ResourceStatus {
fv.lock.RLock()
defer fv.lock.RLock()
defer fv.lock.RUnlock()

return fv.appliedStatusUnsafe
}
Expand Down

0 comments on commit 42e813a

Please sign in to comment.