Skip to content

Commit

Permalink
Update load image timeout based on benchmarking. (#2269)
Browse files Browse the repository at this point in the history
  • Loading branch information
fenxiong authored Nov 8, 2019
1 parent 65fc6b4 commit 0590151
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions agent/dockerclient/timeout.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,14 @@ const (
ListImagesTimeout = 10 * time.Minute
// LoadImageTimeout is the timeout for the LoadImage API. It's set
// to much lower value than pullImageTimeout as it involves loading
// image from either a file or STDIN
// calls involved.
// TODO: Benchmark and re-evaluate this value
LoadImageTimeout = 10 * time.Minute
// image from either a file or STDIN calls involved.
// This value is set based on benchmarking the time of loading the pause container image,
// since it's currently only used to load that image. If this is to be used to load any
// other image in the future, additional benchmarking will be required.
// Per benchmark, 2 min is roughly 4x of the worst case (29s) across 400 image loads on
// al1/al2/al2gpu/al2arm with smallest instance type available (t2.nano/a1.medium) and
// burst balance = 0.
LoadImageTimeout = 2 * time.Minute
// RemoveImageTimeout is the timeout for the RemoveImage API.
RemoveImageTimeout = 3 * time.Minute

Expand Down

0 comments on commit 0590151

Please sign in to comment.