-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace private API encodeURI with public API SigV4_EncodeURI #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/bot run formatting |
…r-AWS-IoT-embedded-sdk into update_unit_tests
tony-josi-aws
previously approved these changes
May 16, 2024
aggarg
reviewed
May 16, 2024
kar-rahul-aws
changed the title
Add unit test for code coverage
Replace private API encodeURI with public API SigV4_EncodeURI
May 16, 2024
aggarg
approved these changes
May 16, 2024
This comment was marked as resolved.
This comment was marked as resolved.
archigup
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant private API
encodeURI
with public APISigV4_EncodeURI
introduced in #89 .Test Steps
Before applying the patch
After applying the patch
Checklist:
Related Issue
#89
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.