Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Goerli #40

Closed
ryansonshine opened this issue Aug 30, 2022 · 2 comments · Fixed by #48
Closed

Upgrade to Goerli #40

ryansonshine opened this issue Aug 30, 2022 · 2 comments · Fixed by #48
Assignees
@ryansonshine

Comments

@ryansonshine
Copy link
Contributor

ryansonshine commented Aug 30, 2022 •
edited
Loading

Since Ropsten has been deprecated, we should update the documentation and any related code to reference Goerli instead.

Note: Sepolia is not an option for AMB at the time of writing.
@Ed-Marcavage
Copy link

Is it possible to use Infura or Alchemy in this project besides AWS AMB?

@ryansonshine ryansonshine mentioned this issue Nov 28, 2022
Closed
@ryansonshine
Copy link
Contributor Author

Is it possible to use Infura or Alchemy in this project besides AWS AMB?

This repository is meant to serve as a demonstration of the capabilities of AWS AMB. It is not recommended that this code be used in production workloads. That being said, if you wanted to fork this repository and create your own version that uses Infura or Alchemy you're more than welcome to.

@ryansonshine ryansonshine self-assigned this Nov 28, 2022
ryansonshine added a commit that referenced this issue Nov 28, 2022
@ryansonshine
feat(goerli): upgrade eth network
9d77b68 
This change upgrades to the Goerli test network since the previous
version used Ropsten which is now entirely deprecated.

fix #40
@ryansonshine ryansonshine mentioned this issue Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryansonshine ryansonshine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(goerli): upgrade eth network aws-samples/simple-nft-marketplace
2 participants
@ryansonshine @Ed-Marcavage