Repository navigation
fix(deps): clear devalue and basic-ftp osv advisories - #935
Merged
Merged
Conversation
Eight advisories published 2026-10-01, after aws-samples#932 merged: - devalue 5.9.2 -> 5.9.4 (GHSA-4q55-j62x-fr9h, GHSA-hx4r-w6wj-j8fg, GHSA-j22f-vq7h-c4qm, GHSA-mcm9-63f2-9j32, GHSA-r9w8-h9r3-54w4, GHSA-wf3x-273g-mvxv, GHSA-x5rw-q4pp-hg5g). Transitive via astro (docs build); within astro's ^5.8.1 range. - basic-ftp 5.3.1 -> 6.2.1 (GHSA-c475-qrg2-pj4r). Transitive via get-uri <- pac-proxy-agent <- proxy-agent <- markdown-link-check / link-check / retire (dev tooling only). No published get-uri accepts 6.x (latest 8.0.1 still pins ^5.3.1), so the resolution forces a major. The only 6.0.0 break is rejecting separate PASV transfer hosts by default (FTP-bounce hardening); get-uri only calls access / lastMod / list / downloadTo, which are unchanged. Root `resolutions` floors added so a re-resolve cannot drop back below the fixed versions. Neither package is in jira-forge-app's lockfile, so no `overrides` mirror is needed; check-transitive-pin-sync stays green.
krokoko
approved these changes
Oct 1, 2026
krokoko
enabled auto-merge
October 1, 2026 18:48
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
=======================================
Coverage ? 92.69%
=======================================
Files ? 344
Lines ? 99835
Branches ? 9994
=======================================
Hits ? 92538
Misses ? 7297
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 1, 2026
This was referenced Oct 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the 8 OSV findings (2 packages) that osv-scanner reports on main. All 8 advisories were published on 2026-10-01, after #932 merged, so this isn't a regression. The advisory database changed under an unchanged lockfile.
Area
tooling— rootmise.toml, scripts, CI workflowsRelated
yarn.lockyarn.lockChanges
package.jsonresolutions: added the floorsdevalue ^5.9.3andbasic-ftp ^6.2.1. Neither package is in jira-forge-app's lockfile, so nooverridesmirror is needed, andcheck-transitive-pin-syncstays green.yarn.lock: re-resolved only these two entries, following the approach from fix(deps): clear 7 osv advisories blocking the merge queue #870 and fix(deps): clear urllib3, brace-expansion, fast-uri osv advisories #932.devalue is transitive through
astro(docs build). 5.9.4 sits inside astro's existing^5.8.1range, so this is a routine bump.basic-ftp crosses a major version, so it needs a reviewer's look. It's transitive through
get-uri←pac-proxy-agent←proxy-agent←markdown-link-check/link-check/retire, which are dev tooling only and not shipped in any deployed artifact. No publishedget-uriaccepts 6.x (latest 8.0.1 still pins^5.3.1), so a forced resolution is the only fix today. The only 6.0.0 breaking change is that separate PASV transfer hosts are rejected by default, which hardens against FTP-bounce attacks.get-urionly callsaccess/lastMod/list/downloadTo, and none of those changed. Onceget-uriwidens its range, this pin can be dropped.Verification:
mise run security:deps(osv-scanner over all three lockfiles) reports No issues found. A fullmise run buildpasses, includingdocs:build(which runs devalue),docs:link-check(which runs the basic-ftp path), and CDK 4783/4783 tests.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.