fix: Correct version pin to support 1.4+ and protect from upcoming provider v5 changes #396
Conversation
…ovider v5 changes
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -1,12 +1,12 @@ | |||
| terraform { | |||
| required_version = "~> 1.3" | |||
There was a problem hiding this comment.
The implementation version restriction further constrain the versions used when provisioning to avoid any surprises. This is different from the module level version constraint (see below)
The ~> puts an upper bound restriction, where this upper bound restriction shown here is preventing from automatically adopting a major version change, but will readily accept a minor and/or patch version change
There was a problem hiding this comment.
We had opened this up to work with TF 1.4, would this prevent that?
There was a problem hiding this comment.
@niallthomson no, the ~> 1.3 allows the rightmost digit to be anything larger than 3.
There was a problem hiding this comment.
whoops - forgot about this. Yes, what @kevcube stated is correct
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = ">= 1.0.0" | |||
| required_version = ">= 1.0" | |||
There was a problem hiding this comment.
Module version constraints are generally only restricted by their lower bound of their requirements, which makes them applicable to a broader range of versions for better adoption without version conflicts. The minimum requirement is derived from the features used, where language level features will raise the Terraform required version, and the provider version will be dictated by the most recent argument addition used across the resources created (i.e. - when was the argument added/updated per the CHANGELOG, this dictates the minimum required provider version)
|
Closing as coming rearchitecture work will address this or make it no longer applicable |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #394
Quality checks
make testormake e2e-testand it was successfulBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.