Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve instability with SG for Pods lab cleanup #1117

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

niallthomson
Copy link
Contributor

What this PR does / why we need it:

User reports and automated tests show instability in the SG for Pods lab cleanup script. This seems to be related to a wide variability in how long it takes the worker nodes to be replaced when they are terminated in cleanup.

This change removes the node termination and instead deletes the catalog namespace, which should clean up all modifications made during this lab.

Which issue(s) this PR fixes:

Related to #1062

Quality checks

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for eks-workshop ready!

Name Link
🔨 Latest commit f161993
🔍 Latest deploy log https://app.netlify.com/sites/eks-workshop/deploys/66f7526c046e390008687341
😎 Deploy Preview https://deploy-preview-1117--eks-workshop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@niallthomson niallthomson merged commit 635eccd into main Sep 28, 2024
10 checks passed
@niallthomson niallthomson deleted the sg-pods-cleanup branch September 28, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant