Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack also to bundle the custom resource code #263

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ottokruse
Copy link
Collaborator

Issue #, if available: N/A

Description of changes: Use webpack also to bundle the custom resource code. This is necessary because we upgraded to Node v20 in #262 which aws-sdk was added as an explicitly included dependency for the custom resources (the Node v20 runtime does not ship it out of the box like v16 would). Unfortunately that blew up the total package size beyond 50 MB, which prevents publishing to SAR. This PR fixes that.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ottokruse ottokruse merged commit 612fddc into aws-samples:master Mar 6, 2024
@ottokruse ottokruse deleted the bundle-custom-resources branch March 6, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant