Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update zlib download use github respository #147

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: update zlib download use github respository #147

merged 1 commit into from
Mar 18, 2024

Conversation

JoaoPedroLucatto
Copy link
Contributor

Motivation

  • Unable to download zlib status code 404

Modifications

  • Changing download url without breaking version compatibility

Testing

  • The change was tested and even generated an image for armv7 architectures, which can be found at. aws-localproxy-32

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

rafaelbmateus
rafaelbmateus approved these changes Feb 20, 2024
View reviewed changes
Copy link

@rafaelbmateus rafaelbmateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarshGandhi-AWS HarshGandhi-AWS merged commit f3c75c7 into aws-samples:main Mar 18, 2024
3 of 13 checks passed
@matyasbach matyasbach mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshGandhi-AWS HarshGandhi-AWS HarshGandhi-AWS approved these changes

@rafaelbmateus rafaelbmateus rafaelbmateus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoaoPedroLucatto @rafaelbmateus @HarshGandhi-AWS