Session History screen #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massi-ang
requested review from
bigadsoleiman
and removed request for
spugachev
| @@ -61,7 +69,7 @@ export default function Sessions(props: SessionsProps) { | |||
|
|
|||
| useEffect(() => { | |||
| if (!appContext) return; | |||
| if (!props.toolsOpen) return; | |||
| //if (!props.toolsOpen) return; | |||
There was a problem hiding this comment.
why this is commented?
There was a problem hiding this comment.
Left over. I need to remove it
bigadsoleiman
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change provides better visibility to Session History feature, and conform with CloudScape design guidelines.
It introduces information panels on most screens and implements a framework to easily add information panels throughout the application.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Session History screen
Delete session
Delete sessions
Settings