Skip to content

Conversation

@KeitaW
Copy link
Contributor

@KeitaW KeitaW commented Jul 23, 2024

Every stage has individual args, hence the following arguments

ARG GDRCOPY_VERSION=v2.4.1
ARG EFA_INSTALLER_VERSION=1.33.0
ARG AWS_OFI_NCCL_VERSION=v1.9.2-aws
ARG NCCL_VERSION=v2.21.5-1
ARG NCCL_TESTS_VERSION=v2.13.9

cannot be retrieved under the FROM statement:

#6 [ 2/19] RUN echo "Versions: CUDA=12.2.2 GDDRCOPY=${GDRCOPY_VERSION} EFA=${EFA_INSTALLER_VERSION} OFI=${AWS_OFI_NCCL_VERSION} NCCL=2.19.3-1 TESTS=${NCCL_TESTS_VERSION}"
#6 0.212 Versions: CUDA=12.2.2 GDDRCOPY= EFA= OFI= NCCL=2.19.3-1 TESTS=

this PR is suggest to put them right after the FROM statement.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@KeitaW
Copy link
Contributor Author

KeitaW commented Jul 23, 2024

docker/cli#333 (comment)

Copy link
Contributor

@iankouls-aws iankouls-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Only CUDA_VERSION needs to be above the FROM line

@iankouls-aws iankouls-aws merged commit 1eabdf9 into aws-samples:main Jul 23, 2024
@KeitaW
Copy link
Contributor Author

KeitaW commented Jul 23, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants