Skip to content

Conversation

@kristianpaul
Copy link
Contributor

@kristianpaul kristianpaul commented May 1, 2020

With this pull request I want to publish a CDK Python example that deploys an EC2 instance taking advantage of AWS services like System Manager, Amazon Linux 2 AMI and CDK Assets to package scripts that provision instance as needed.

  • Own VPC with public subnet (following AWS Defaults for new accounts)
  • Based on latest Amazon Linux 2
  • System Manager replaces SSH (Remote session available trough the AWS Console or the AWS CLI.)
  • Userdata executed from script in S3 bucket (configuration.sh).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify
Copy link
Contributor

mergify bot commented May 1, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@kristianpaul kristianpaul changed the title cdk example ec2 in vpc with ssm feat: Add CDK Example ec2 in vpc with ssm May 1, 2020
rix0rrr
rix0rrr previously requested changes May 6, 2020
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this example to the top-level README

@mergify mergify bot dismissed rix0rrr’s stale review May 10, 2020 02:54

Pull request has been modified.

@kristianpaul kristianpaul force-pushed the ec2-vpc-ssm-example branch from 330cd55 to 849a3cb Compare May 10, 2020 03:42
@rix0rrr rix0rrr assigned NGL321 and SomayaB and unassigned rix0rrr May 14, 2020
@kristianpaul kristianpaul force-pushed the ec2-vpc-ssm-example branch from 97aebc3 to 39bf556 Compare May 17, 2020 21:45
@mergify
Copy link
Contributor

mergify bot commented May 17, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@SomayaB SomayaB removed their assignment May 27, 2020
NGL321
NGL321 previously approved these changes May 28, 2020
Copy link
Contributor

@NGL321 NGL321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks excellent! Lets get it merged.

😸 😷

@mergify mergify bot dismissed NGL321’s stale review May 28, 2020 02:43

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented May 28, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 6d9a3a0 into aws-samples:master May 28, 2020
its-mirus-lu pushed a commit to its-mirus-lu/aws-cdk-examples that referenced this pull request Mar 26, 2022
* feat: add cdk example ec2 in vpc with ssm

* fix s3 script name

Co-authored-by: Noah Litov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants