Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services resource rule to agent cluster role #167

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

movence
Copy link
Contributor

@movence movence commented May 9, 2024

Description of the issue

CWAgent cluster role yaml file is missing services rule in the quickstart guide for ContainerInsights which is causing the agent to throw errors.

Description of changes

  • Add missing services resource rule to agent's cluster role yaml

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Followed the quick start guide with the updated clusterrole yaml file on a fresh testing cluster. Confirmed the agent is not throwing any errors with this change.

Requirements

Before committing the code, please verify the following:

  • If this commit includes changes to existing sample configurations, you acknowledge that you have confirmed this will not impact existing customer behavior.
  • If not necessary, consider creating a new sample configuration for this change.

Copy link

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants