Remove unnecessary tolerations from fluent-bit pods #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove unnecessary tolerations from fluent-bit pods. These tolerations were far too broad and caused scheduling of these pods onto Fargate nodes, where daemonsets aren't supported. Customers can apply their own site-specific tolerations as necessary.
There weren't similar tolerations for the cloudwatch-agent daemonset, so the impact on existing clusters should be only to remove fluent-bit pods from tainted nodes. Again, customers can apply their own specific tolerations if they desire fluent-bit to be rescheduled on tainted nodes.
Fixes #61
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.