Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus metrics collection for Karpenter #135

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

mikereinhold
Copy link

Issue

Related to #134

Description of changes:

Add sample configuration for collecting Karpenter metrics

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@SaxyPandaBear SaxyPandaBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the AWS public docs mention installation and configuration of Karpenter. This seems out of place here.

@mikereinhold
Copy link
Author

Hi @SaxyPandaBear - the thought process is twofold:

  1. This Container Insights sample is pre-configured for common workloads that expose Prometheus metrics like nginx, memcached, Java, HaProxy. The AWS documentation doesn't explicitly describe how to install and configure each of these software packages either, however the sample still includes a configuration for them because it's useful to Container Insights users out of the box.
  2. Karpenter is an AWS project and exposes Prometheus metrics. It's not unreasonable to assume that EKS & Container Insights customers will use Karpenter more in the future as the project grows and it is desirable to simplify that setup by including it in the sample configuration. Additionally, it seems logical that AWS should provide sample configurations for integrating across AWS projects, like Container Insights and Karpenter.

If I was being cheeky, I'd also say that the Karpenter docs at https://karpenter.sh/ are AWS public docs and they do describe how to install and configure Karpenter 😆

@SaxyPandaBear
Copy link
Contributor

Thanks for the much needed context. This is legitimately the first time I'm hearing about Karpenter. I'll bring it up with the team next week to see if this is on anyone's radar. I think more importantly than just putting a config sample here is coordinating with updating AWS CloudWatch public docs - to my understanding, that's the whole point of this repo. I think deciding to add Karpenter to CloudWatch on EKS docs will be a deciding factor on accepting this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants