-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus metrics collection for Karpenter #135
base: main
Are you sure you want to change the base?
Conversation
Based on sample found in the Karpenter Getting Started Guide (https://karpenter.sh/v0.27.3/getting-started/getting-started-with-karpenter/prometheus-values.yaml)
Based on the metrics in v0.27.3 as documented here: https://karpenter.sh/v0.27.3/concepts/metrics/
Add missed provisioner*resource_type section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the AWS public docs mention installation and configuration of Karpenter. This seems out of place here.
Hi @SaxyPandaBear - the thought process is twofold:
If I was being cheeky, I'd also say that the Karpenter docs at https://karpenter.sh/ are AWS public docs and they do describe how to install and configure Karpenter 😆 |
Thanks for the much needed context. This is legitimately the first time I'm hearing about Karpenter. I'll bring it up with the team next week to see if this is on anyone's radar. I think more importantly than just putting a config sample here is coordinating with updating AWS CloudWatch public docs - to my understanding, that's the whole point of this repo. I think deciding to add Karpenter to CloudWatch on EKS docs will be a deciding factor on accepting this change |
Issue
Related to #134
Description of changes:
Add sample configuration for collecting Karpenter metrics
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.