fix(parser): body/QS can be null or omitted in apigw v1/v2 #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## develop #820 +/- ##
========================================
Coverage 99.90% 99.90%
========================================
Files 118 118
Lines 5107 5107
Branches 279 279
========================================
Hits 5102 5102
Misses 2 2
Partials 3 3
Continue to review full report at Codecov.
|
heitorlessa
changed the title
|
Same issue with API Gateway HTTP API v2 payload, including query strings. payload where API GW v2 omit keys {
"version": "2.0",
"routeKey": "GET /users",
"rawPath": "/users",
"rawQueryString": "",
"headers": {
"accept": "*/*",
"content-length": "0",
"host": "3mblkdfe53.execute-api.eu-west-1.amazonaws.com",
"referer": "",
"user-agent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)",
"x-amzn-trace-id": "Root=1-618ffb41-0934497356e94b96397ed34e",
"x-forwarded-for": "83.81.50.30",
"x-forwarded-port": "443",
"x-forwarded-proto": "https"
},
"requestContext": {
"accountId": "231436140809",
"apiId": "3mblkdfe53",
"domainName": "3mblkdfe53.execute-api.eu-west-1.amazonaws.com",
"domainPrefix": "3mblkdfe53",
"http": {
"method": "GET",
"path": "/users",
"protocol": "HTTP/1.1",
"sourceIp": "83.81.50.30",
"userAgent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)"
},
"requestId": "IwQyOgctDoEEJMA=",
"routeKey": "GET /users",
"stage": "$default",
"time": "13/Nov/2021:17:52:01 +0000",
"timeEpoch": 1636825921268
},
"isBase64Encoded": false
} |
heitorlessa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #797
Description of changes:
Parser incorrectly expected
bodyto always be non-empty; this addresses it.Actual event tested to repro #797
{ "body": null, "resource": "/users", "path": "/users", "httpMethod": "GET", "headers": { "Accept": "*/*", "CloudFront-Forwarded-Proto": "https", "CloudFront-Is-Desktop-Viewer": "true", "CloudFront-Is-Mobile-Viewer": "false", "CloudFront-Is-SmartTV-Viewer": "false", "CloudFront-Is-Tablet-Viewer": "false", "CloudFront-Viewer-Country": "NL", "Host": "a1c2k0n4x4.execute-api.eu-west-1.amazonaws.com", "User-Agent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)", "Via": "2.0 b619a16f6f8fe9793bf642d2a8434284.cloudfront.net (CloudFront)", "X-Amz-Cf-Id": "sj5uo2ZyuF8WvtxH6IYxHMQFHCuMWaD-xE5T-7WFZR28Jz-Kp4Zvsw==", "X-Amzn-Trace-Id": "Root=1-618ff3e6-6e0fdf4f4197d0e7437264dd", "X-Forwarded-For": "83.41.50.10, 54.200.158.122", "X-Forwarded-Port": "443", "X-Forwarded-Proto": "https" }, "multiValueHeaders": { "Accept": [ "*/*" ], "CloudFront-Forwarded-Proto": [ "https" ], "CloudFront-Is-Desktop-Viewer": [ "true" ], "CloudFront-Is-Mobile-Viewer": [ "false" ], "CloudFront-Is-SmartTV-Viewer": [ "false" ], "CloudFront-Is-Tablet-Viewer": [ "false" ], "CloudFront-Viewer-Country": [ "NL" ], "Host": [ "a1c2k0n4x4.execute-api.eu-west-1.amazonaws.com" ], "User-Agent": [ "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)" ], "Via": [ "2.0 b619a16f6f8fe9793bf642d2a8434284.cloudfront.net (CloudFront)" ], "X-Amz-Cf-Id": [ "sj5uo2ZyuF8WvtxH6IYxHMQFHCuMWaD-xE5T-7WFZR28Jz-Kp4Zvsw==" ], "X-Amzn-Trace-Id": [ "Root=1-618ff3e6-6e0fdf4f4197d0e7437264dd" ], "X-Forwarded-For": [ "83.41.50.10, 54.200.158.122" ], "X-Forwarded-Port": [ "443" ], "X-Forwarded-Proto": [ "https" ] }, "queryStringParameters": null, "multiValueQueryStringParameters": null, "pathParameters": null, "stageVariables": null, "requestContext": { "resourceId": "sfqe1d", "resourcePath": "/users", "httpMethod": "GET", "extendedRequestId": "IwMMEGaOjoEF_zw=", "requestTime": "13/Nov/2021:17:20:38 +0000", "path": "/Prod/users", "accountId": "231436140809", "protocol": "HTTP/1.1", "stage": "Prod", "domainPrefix": "a1c2k0n4x4", "requestTimeEpoch": 1636824038666, "requestId": "4fdd98f4-0570-46cb-b683-b0d02afe9dca", "identity": { "cognitoIdentityPoolId": null, "accountId": null, "cognitoIdentityId": null, "caller": null, "sourceIp": "83.41.50.10", "principalOrgId": null, "accessKey": null, "cognitoAuthenticationType": null, "cognitoAuthenticationProvider": null, "userArn": null, "userAgent": "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)", "user": null }, "domainName": "a1c2k0n4x4.execute-api.eu-west-1.amazonaws.com", "apiId": "a1c2k0n4x4" }, "isBase64Encoded": false }Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.