Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): add AWS Transfer Family model #5906

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5903

Summary

Changes

This PR adds a model to parser AWS Transfer Family events for FTP, FTPS, SFTP

User experience

from aws_lambda_powertools.utilities.parser import parse
from aws_lambda_powertools.utilities.parser.models import TransferFamily
from aws_lambda_powertools.utilities.typing import LambdaContext


def lambda_handler(event: TransferFamily, context: LambdaContext) -> list:
    parsed_event = parse(model=TransferFamily, event=event)

    ...

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 23, 2025 13:10
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation tests labels Jan 23, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 23, 2025
@leandrodamascena leandrodamascena linked an issue Jan 23, 2025 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena self-assigned this Jan 23, 2025
@github-actions github-actions bot added feature New feature or functionality and removed documentation Improvements or additions to documentation labels Jan 23, 2025
@leandrodamascena leandrodamascena added documentation Improvements or additions to documentation parser Parser (Pydantic) utility and removed feature New feature or functionality labels Jan 23, 2025
@github-actions github-actions bot added feature New feature or functionality and removed documentation Improvements or additions to documentation labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (553e733) to head (a9a0215).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5906   +/-   ##
========================================
  Coverage    96.22%   96.22%           
========================================
  Files          232      233    +1     
  Lines        10955    10965   +10     
  Branches       790      790           
========================================
+ Hits         10541    10551   +10     
  Misses         327      327           
  Partials        87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anafalcao anafalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR, @leandrodamascena ! Great job

@leandrodamascena leandrodamascena merged commit 7a05f43 into develop Jan 23, 2025
25 checks passed
@leandrodamascena leandrodamascena deleted the parser/transferfamily branch January 23, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality parser Parser (Pydantic) utility size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Add AWS Transfer Family parser models
2 participants