Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): drop support for Python 3.8 #5896

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5238

Summary

Changes

On 2024-10-25, we announced the deprecation of Python 3.8 in Powertools, scheduled for 2025-02-07. During this time, we continued to release versions for Python 3.8 and allowed customers to migrate to newer versions of Python without any impact.

AWS Lambda

AWS Lambda runtime will fully deprecate Python 3.8 on Mar 31, 2025. This means, 3.8 functions will be unable to be updated. Inline with this, Powertools releases will stop supporting it.

We strongly advice you update your Lambda functions to at least Python 3.10+.

User experience

Customers will no longer be able to use Powertools for AWS Lambda (Python) with Python 3.8.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner January 22, 2025 14:50
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code tests labels Jan 22, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2025
@github-actions github-actions bot added internal Maintenance changes and removed documentation Improvements or additions to documentation labels Jan 22, 2025
@leandrodamascena leandrodamascena linked an issue Jan 22, 2025 that may be closed by this pull request
2 tasks
@leandrodamascena leandrodamascena self-assigned this Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (792892e) to head (921e058).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5896      +/-   ##
===========================================
+ Coverage    96.20%   96.22%   +0.01%     
===========================================
  Files          232      232              
  Lines        10955    10955              
  Branches      2026      790    -1236     
===========================================
+ Hits         10539    10541       +2     
  Misses         327      327              
+ Partials        89       87       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-templates labels Jan 22, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 22, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 22, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 22, 2025
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 22, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 22, 2025
dreamorosi
dreamorosi previously approved these changes Jan 22, 2025
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

Leaving a comment, but feel free to not implement it, if you think it's not useful:

The upgrade guide from v2 to v3 currently says to migrate to at least 3.8. That was true at that time, but if someone follows the guide next week they might get stuck since the version at that time doesn't support it anymore. Not sure you want to change it or call out that we dropped support.

Other than this, good to go.

@leandrodamascena
Copy link
Contributor Author

The upgrade guide from v2 to v3 currently says to migrate to at least 3.8. That was true at that time, but if someone follows the guide next week they might get stuck since the version at that time doesn't support it anymore. Not sure you want to change it or call out that we dropped support.

You're right here and it's a good point, but I don't think we should be encouraging customers to adopt 3.8 anymore, especially since if someone is migrating from version 2 to version 3 and sticking with Python 3.8, that means they have less than 2 months to get everything done and never change a single line of code in that function again because AWS Lambda will drop update function soon.

What do you think about waiting for someone to open an issue or complain about it? Then we can provide specific answers to specific requests, that is, if they happen.

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 23, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 23, 2025
@dreamorosi
Copy link
Contributor

The upgrade guide from v2 to v3 currently says to migrate to at least 3.8. That was true at that time, but if someone follows the guide next week they might get stuck since the version at that time doesn't support it anymore. Not sure you want to change it or call out that we dropped support.

You're right here and it's a good point, but I don't think we should be encouraging customers to adopt 3.8 anymore, especially since if someone is migrating from version 2 to version 3 and sticking with Python 3.8, that means they have less than 2 months to get everything done and never change a single line of code in that function again because AWS Lambda will drop update function soon.

What do you think about waiting for someone to open an issue or complain about it? Then we can provide specific answers to specific requests, that is, if they happen.

Sorry I haven't been clear maybe.

My suggestion was to update the text in the upgrade guide to say "upgrade to at least 3.9".

@leandrodamascena
Copy link
Contributor Author

My suggestion was to update the text in the upgrade guide to say "upgrade to at least 3.9".

This: https://github.com/aws-powertools/powertools-lambda-python/pull/5896/files#diff-3ec187be4d5027db52c481841dbbf321b2f4b39dea03033c971aeba9a4a20e51R34?

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 23, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Jan 23, 2025
@dreamorosi dreamorosi self-requested a review January 23, 2025 12:10
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for addressing my comments.

@leandrodamascena leandrodamascena merged commit 553e733 into develop Jan 23, 2025
16 checks passed
@leandrodamascena leandrodamascena deleted the drop-python38 branch January 23, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code github-templates internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
Status: Coming soon
Development

Successfully merging this pull request may close these issues.

Maintenance: drop support for Python 3.8
2 participants