-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): drop support for Python 3.8 #5896
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5896 +/- ##
===========================================
+ Coverage 96.20% 96.22% +0.01%
===========================================
Files 232 232
Lines 10955 10955
Branches 2026 790 -1236
===========================================
+ Hits 10539 10541 +2
Misses 327 327
+ Partials 89 87 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
Leaving a comment, but feel free to not implement it, if you think it's not useful:
The upgrade guide from v2 to v3 currently says to migrate to at least 3.8. That was true at that time, but if someone follows the guide next week they might get stuck since the version at that time doesn't support it anymore. Not sure you want to change it or call out that we dropped support.
Other than this, good to go.
You're right here and it's a good point, but I don't think we should be encouraging customers to adopt 3.8 anymore, especially since if someone is migrating from version 2 to version 3 and sticking with Python 3.8, that means they have less than 2 months to get everything done and never change a single line of code in that function again because AWS Lambda will drop update function soon. What do you think about waiting for someone to open an issue or complain about it? Then we can provide specific answers to specific requests, that is, if they happen. |
Sorry I haven't been clear maybe. My suggestion was to update the text in the upgrade guide to say "upgrade to at least 3.9". |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and for addressing my comments.
Issue number: #5238
Summary
Changes
On 2024-10-25, we announced the deprecation of Python 3.8 in Powertools, scheduled for 2025-02-07. During this time, we continued to release versions for Python 3.8 and allowed customers to migrate to newer versions of Python without any impact.
AWS Lambda
AWS Lambda runtime will fully deprecate Python 3.8 on Mar 31, 2025. This means, 3.8 functions will be unable to be updated. Inline with this, Powertools releases will stop supporting it.
We strongly advice you update your Lambda functions to at least Python 3.10+.
User experience
Customers will no longer be able to use Powertools for AWS Lambda (Python) with Python 3.8.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.