-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): add context manager for logger keys #5883
Conversation
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5883 +/- ##
========================================
Coverage 96.19% 96.20%
========================================
Files 232 232
Lines 10941 10956 +15
Branches 2023 2027 +4
========================================
+ Hits 10525 10540 +15
Misses 327 327
Partials 89 89 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anafalcao! Thanks a lot for working on this, another super cool PR!
I left some feedback to improve the customer experience and make it even better.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another super super nice PR @anafalcao! Congratulations for having such a sense of ownership and innovating on behalf of our customer!
Parabéns 🎆
Can we look at these? |
This is literally SonarQube complaining about a new fake class for test with a very common practice: abstracting a class with I'll mark them a false positive. |
Issue number: #5864
Additional issues: #3719 #2062
Summary
This PR adds the
append_context_keys
method, and it allows temporary modification of a Logger instance's context without creating a new logger.Changes
New method to Logger formatter -
append_context_keys()
. This PR also adds more tests and documentation for this method.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.