Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bump minimum required pydantic version #5446

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #5437

Summary

Changes

This PR updates the minimum required version of Pydantic in our project.toml file to 2.4.0. This change aims to prevent the installation of versions with known CVEs and address potential SAST tool complaints.

While our current setup installs the latest Pydantic version when users use our layers or install aws-lambda-powertools[all/tracer], it doesn't prevent users from manually installing older versions with known vulnerabilities. This update ensures a minimum safe version is specified.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner October 24, 2024 12:06
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Oct 24, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2024
Copy link

@github-actions github-actions bot added internal Maintenance changes and removed documentation Improvements or additions to documentation labels Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (0f545c6) to head (db25740).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5446   +/-   ##
========================================
  Coverage    96.15%   96.15%           
========================================
  Files          229      229           
  Lines        10806    10806           
  Branches      2006     2006           
========================================
  Hits         10391    10391           
  Misses         327      327           
  Partials        88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sthulb sthulb merged commit c11d25c into develop Oct 24, 2024
21 of 22 checks passed
@sthulb sthulb deleted the pydantic/minimum branch October 24, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: pyproject.toml and poetry.lock dependency versions appear at odds
2 participants