Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): reverting SSM parameter name #5340

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Oct 8, 2024

Issue number: #5339

Summary

Changes

We need to revert the name change for internal parameter names for the Canary stack. In CloudFormation, the Canary stack represents a changeset when deploying, and we'll need to remove all the Canary stacks in all regions to use the new parameter name. These parameter names are used internally within our CloudFormation templates and are not exposed to end customers.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner October 8, 2024 08:52
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2024
@leandrodamascena leandrodamascena merged commit d3173f3 into develop Oct 8, 2024
9 checks passed
@leandrodamascena leandrodamascena deleted the rename-ssm branch October 8, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants