fix(validator): handle built-in custom formats correctly #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #496
Description of changes:
JSONSchema Draft 7 has support for custom built-in formats like
date-time
. This PR fixes a malformed input to the upstream JSON validator (fastjsonschema
) which cannot differentiate between custom format and custom built-in formats.If no custom formats are explicitly passed we default to a Dict when passing that as input to
fastjsonschema
. This leads to the right fallback mechanism in the upstream validator to search for built-in custom formats.Example JSON schema field that triggered it:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.