Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): introduce tests with Nox #4537

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #4519

Additional issue: #4520

Summary

Changes

This PR introduces the use of Nox for testing specific dependencies in each feature we have. This is essential to prevent regressions.

Using Nox allows us to test the behavior of required/optional dependencies during our tests. This way, we can isolate the feature being tested from the actual implementation of its dependencies, making the tests more reliable, consistent, and not adding anything that require extras libraries. With this we can catch potential regressions early in the development process, before they make it to the prod.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes tests labels Jun 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (e14e768) to head (d198233).
Report is 599 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4537      +/-   ##
===========================================
+ Coverage    96.38%   96.43%   +0.05%     
===========================================
  Files          214      219       +5     
  Lines        10030    10626     +596     
  Branches      1846     1976     +130     
===========================================
+ Hits          9667    10247     +580     
- Misses         259      267       +8     
- Partials       104      112       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena marked this pull request as ready for review June 17, 2024 17:54
@leandrodamascena leandrodamascena requested a review from a team as a code owner June 17, 2024 17:54
@leandrodamascena leandrodamascena changed the title chore(ci): introduce tests witn Nox chore(ci): introduce tests with Nox Jun 18, 2024
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor improvements to make it more explicit.

THIS IS AWESOOOOOME! Waited for long to have this tech debt finally resolved.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeeet! ship it

@heitorlessa heitorlessa merged commit 07ef4da into aws-powertools:develop Jun 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add the Logger feature to nox tests Maintenance: Install and configure nox
2 participants