-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): introduce tests with Nox #4537
chore(ci): introduce tests with Nox #4537
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4537 +/- ##
===========================================
+ Coverage 96.38% 96.43% +0.05%
===========================================
Files 214 219 +5
Lines 10030 10626 +596
Branches 1846 1976 +130
===========================================
+ Hits 9667 10247 +580
- Misses 259 267 +8
- Partials 104 112 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor improvements to make it more explicit.
THIS IS AWESOOOOOME! Waited for long to have this tech debt finally resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweeeet! ship it
Issue number: #4519
Additional issue: #4520
Summary
Changes
This PR introduces the use of Nox for testing specific dependencies in each feature we have. This is essential to prevent regressions.
Using Nox allows us to test the behavior of required/optional dependencies during our tests. This way, we can isolate the feature being tested from the actual implementation of its dependencies, making the tests more reliable, consistent, and not adding anything that require extras libraries. With this we can catch potential regressions early in the development process, before they make it to the prod.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.