Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(feature_flags): fix incorrect line markers and envelope name #3792

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

ran-isenberg
Copy link
Contributor

Issue number: #3791

Summary

Fix line markers & envelope example to the correct sub dict in the json configuration.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ran-isenberg ran-isenberg requested a review from a team as a code owner February 18, 2024 13:06
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Feb 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2024
@rubenfonseca rubenfonseca linked an issue Feb 19, 2024 that may be closed by this pull request
1 task
@rubenfonseca rubenfonseca added the feature_flags Feature Flags utility label Feb 19, 2024
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you Ran!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rubenfonseca rubenfonseca changed the title docs: fix incorrect line markers and envelope name docs(feature_flags): fix incorrect line markers and envelope name Feb 19, 2024
@rubenfonseca rubenfonseca merged commit 48f705f into aws-powertools:develop Feb 19, 2024
5 checks passed
@ran-isenberg ran-isenberg deleted the appconfig1 branch February 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature_flags Feature Flags utility size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Fix feature flags documentation
2 participants