-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(middleware-factory): Fix and improve typing #3569
docs(middleware-factory): Fix and improve typing #3569
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kamilturek, you were very quick to send this PR! I left some comments before merging 🚀
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Hey @leandrodamascena, thanks for reviewing the PR! I agree with your comments. I've just pushed an update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!! Thanks a lot @kamilturek!
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Issue number: #3556
Summary
Changes
This PR fixes middleware factory examples by changing invalid
Callable
return types todict
, and adds type annotations for other middleware arguments.User experience
N/A
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.