docs(event_handler): demonstrate how to combine logger correlation ID and middleware #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
Signed-off-by: heitorlessa <[email protected]>
* develop: chore: cleanup, add test for single and nested fix(parameters): make cache aware of single vs multiple calls docs(event_handler): use correct correlation_id for logger in middleware example (aws-powertools#3063) chore(deps-dev): bump pytest from 7.4.1 to 7.4.2 (aws-powertools#3057)
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
documentation
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
github-actions
bot
added
do-not-merge
need-issue
sthulb
previously approved these changes
Sep 8, 2023
sthulb
previously approved these changes
Sep 8, 2023
Signed-off-by: heitorlessa <[email protected]>
pull-request-size
bot
added
size/S
|
Kudos, SonarCloud Quality Gate passed!
|
sthulb
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2917
Summary
Tiny change to address a customer's question on how to use Logger to extract correlation ID from a dynamic part of the payload, and fallback to a request ID if not available.
PS. Discussed with @sthulb that this should be a built-in feature to inject into the context, so customers don't depend on Logger for getting correlation ID nor yet another middleware.
For example:
app = ApiGatewayRestResolver(correlation_id_path="headers...")Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.