Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logging import to use vended version #3

Merged
merged 3 commits into from
Jan 9, 2020
Merged

fix: logging import to use vended version #3

merged 3 commits into from
Jan 9, 2020

Conversation

nmoutschen
Copy link
Contributor

Issue #, if available: aws-powertools/powertools-lambda#2

Description of changes:

  • Fix logging import to use the vended version in aws_lambda_powertools.logging.aws_lambda_logging
  • Fix test cases to use the vended version instead
  • Remove test cases that cover aws_lambda_logging.wrap as wrap is not present in the vended version

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa self-requested a review January 9, 2020 10:42
heitorlessa added a commit that referenced this pull request Jan 9, 2020
@heitorlessa
Copy link
Contributor

Could you make a dummy commit to test the CI ? :D

@heitorlessa heitorlessa merged commit 780addb into aws-powertools:develop Jan 9, 2020
@heitorlessa heitorlessa added bug Something isn't working enhancement and removed bug Something isn't working labels Jun 3, 2020
@heitorlessa heitorlessa changed the title Fix logging import fix: logging import to use vended version Jun 3, 2020
@heitorlessa heitorlessa added bug Something isn't working and removed enhancement labels Jun 3, 2020
heitorlessa referenced this pull request in heitorlessa/aws-lambda-powertools-python Jun 17, 2020
Fix logging import. Resolves #3
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label May 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This is now released under 2.16.1 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants